GH Actions: add actionlint job #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a separate job to the `reusable-yamllint` workflow to validate the (reusable) workflows against common errors and potential problems and show the results inline in pull requests. In particular, this is intended to protect against errors being introduced in the reusable workflows, as not all of those are run from within this repo, so errors would only be discovered via a failing build in _another_ repo, which does run the reusable workflow. This new job is intended to prevent this potential issue. As this is a reusable workflow, other repos using this workflow will automatically inherit this job. While this may not be _strictly_ necessary (as for other repos, the workflows will generally always be run), it also doesn't do any harm to have that extra verification in place. Loosely based on wp-cli/.github 111 Refs: * https://github.com/rhysd/actionlinthttps://github.com/rhysd/actionlint * https://github.com/rhysd/actionlint/blob/main/docs/README.md Co-authored-by: Thorsten Frommen <[email protected]>
jrfnl
force-pushed
the
feature/validate-reusable-workflows
branch
from
1c14d48
to
dbd8014
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a separate job to the
reusable-yamllintworkflow to validate the (reusable) workflows against common errors and potential problems and show the results inline in pull requests.In particular, this is intended to protect against errors being introduced in the reusable workflows, as not all of those are run from within this repo, so errors would only be discovered via a failing build in another repo, which does run the reusable workflow. This new job is intended to prevent this potential issue.
As this is a reusable workflow, other repos using this workflow will automatically inherit this job. While this may not be strictly necessary (as for other repos, the workflows will generally always be run), it also doesn't do any harm to have that extra verification in place.
Loosely based on wp-cli/.github#111
Refs: